🤖 Add release workflow for automated binary publishing #168
+121
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
- Create release.yml workflow triggered on release publish - Configure electron-builder to publish to GitHub releases - Add workflow documentation explaining release process - Keep build steps in sync with build.yml for consistency Release process: 1. Bump version in package.json 2. Create draft release with notes on GitHub 3. Publish release → workflow builds and attaches binaries 4. Users download from GitHub releases The workflow reuses the same build setup as build.yml but publishes artifacts to GitHub releases instead of workflow artifacts.
- Create composite action .github/actions/setup-cmux for common setup - Reduces 4 steps (checkout, bun, install, build) to 1 step - Extract macOS code signing to scripts/setup-macos-signing.sh - Reduces ~17 lines of inline bash to 1 step - Makes signing logic testable locally - Update build.yml to use composite action and signing script - Update release.yml to use composite action and signing script Benefits: - Single source of truth for build setup - Changes to build process update both workflows - Workflows are more readable (fewer lines) - Code signing script can be tested independently
Add contents: write permission so electron-builder can upload binaries to GitHub releases. Without this, the default token only has read access and uploads fail with 403.
ammar-agent
force-pushed
the
add-release-workflow
branch
from
c4570b6 to
e49d451
Compare
ImageMagick must be installed before building (for icon generation), so the build step needs to happen after platform-specific setup.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Icons are generated during build, so ImageMagick must be installed before building in both CI and release workflows.
|
@codex review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds automated release workflow that builds and publishes macOS and Linux binaries when a GitHub release is published.
Release Process
Changes
release: published--publish alwaysto attach artifacts to GitHub releaseDRY Approach
The release workflow reuses the same build setup as :
Key difference: uses for PR verification, while uses with to attach binaries to releases.
Testing
This can be tested by:
Generated with
cmux